Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use platforms instead of bazel_tools for windows constraint #3315

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

zaucy
Copy link
Contributor

@zaucy zaucy commented Mar 15, 2021

Our projects are using the platforms API and our targets that use googletest were failing to build due to using @bazel_tools//platforms.

ERROR: C:/users/zekew/_bazel_zekew/5hhwqc6f/external/bazel_tools/platforms/BUILD:79:6: in alias rule @bazel_tools//platforms:windows: Constraints from @bazel_tools//platforms have been removed. Please use constraints from @platforms repository embedded in Bazel, or 
preferably declare dependency on https://github.com/bazelbuild/platforms. See https://github.com/bazelbuild/bazel/issues/8622 for details.
ERROR: While resolving configuration keys for @com_google_googletest//:gtest: Analysis of target '@bazel_tools//platforms:windows' failed

@google-cla google-cla bot added the cla: yes label Mar 15, 2021
@derekmauro derekmauro self-assigned this Mar 15, 2021
asoffer pushed a commit that referenced this pull request Mar 18, 2021
PiperOrigin-RevId: 363176008
@asoffer asoffer merged commit 3ff1e8b into google:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants