Refactor finding python #3114
Merged
Refactor finding python #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `find_package(Python ..)` if available, instead of the deprecated `find_package(PythonInterp)` CMake module.
|
@ScottTodd: FYI. This might relax the problems we experience within IREE. |
|
Another or rather an additional option that relaxes problems for projects embedding googletest would be to disable finding python if |
abdulbade1991
approved these changes
Nov 11, 2020
|
Thank you for this PR! It has now been imported for internal testing. Please do not modify it further as the changes will be overwritten. (342837512) |
derekmauro
added a commit
that referenced
this pull request
Nov 19, 2020
PiperOrigin-RevId: 342977338
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
find_package(Python ..)if available, instead of the deprecatedfind_package(PythonInterp)CMake module.