Skip to content

Commit

Permalink
Merge pull request #3364 from jbampton:fix-spelling
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 369217358
  • Loading branch information
Andy Soffer committed Apr 21, 2021
2 parents eaf9a3f + 050b517 commit 566fdcc
Show file tree
Hide file tree
Showing 12 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion googlemock/include/gmock/gmock-matchers.h
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ class MatcherCastImpl {
// constructor from M (this usually happens when T has an implicit
// constructor from any type).
//
// It won't work to unconditionally implict_cast
// It won't work to unconditionally implicit_cast
// polymorphic_matcher_or_value to Matcher<T> because it won't trigger
// a user-defined conversion from M to T if one exists (assuming M is
// a value).
Expand Down
6 changes: 3 additions & 3 deletions googlemock/scripts/generator/cpp/ast.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ def Requires(self, node):
# TODO(nnorwitz): handle namespaces, etc.
if self.bases:
for token_list in self.bases:
# TODO(nnorwitz): bases are tokens, do name comparision.
# TODO(nnorwitz): bases are tokens, do name comparison.
for token in token_list:
if token.name == node.name:
return True
Expand Down Expand Up @@ -379,7 +379,7 @@ def IsExportable(self):

def Requires(self, node):
if self.parameters:
# TODO(nnorwitz): parameters are tokens, do name comparision.
# TODO(nnorwitz): parameters are tokens, do name comparison.
for p in self.parameters:
if p.name == node.name:
return True
Expand Down Expand Up @@ -895,7 +895,7 @@ def _GetVarTokensUpToIgnoringTemplates(self, expected_token_type,
nesting -= 1
return tokens, last_token

# TODO(nnorwitz): remove _IgnoreUpTo() it shouldn't be necesary.
# TODO(nnorwitz): remove _IgnoreUpTo() it shouldn't be necessary.
def _IgnoreUpTo(self, token_type, token):
unused_tokens = self._GetTokensUpTo(token_type, token)

Expand Down
2 changes: 1 addition & 1 deletion googlemock/test/gmock-actions_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ TEST(DoDefaultDeathTest, DiesIfUsedInCompositeAction) {
}

// Tests that DoDefault() returns the default value set by
// DefaultValue<T>::Set() when it's not overriden by an ON_CALL().
// DefaultValue<T>::Set() when it's not overridden by an ON_CALL().
TEST(DoDefaultTest, ReturnsUserSpecifiedPerTypeDefaultValueWhenThereIsOne) {
DefaultValue<int>::Set(1);
MockClass mock;
Expand Down
2 changes: 1 addition & 1 deletion googletest/include/gtest/gtest.h
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ class GTEST_API_ TestResult {

// Protects mutable state of the property vector and of owned
// properties, whose values may be updated.
internal::Mutex test_properites_mutex_;
internal::Mutex test_properties_mutex_;

// The vector of TestPartResults
std::vector<TestPartResult> test_part_results_;
Expand Down
2 changes: 1 addition & 1 deletion googletest/include/gtest/internal/gtest-filepath.h
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class GTEST_API_ FilePath {

void Normalize();

// Returns a pointer to the last occurence of a valid path separator in
// Returns a pointer to the last occurrence of a valid path separator in
// the FilePath. On Windows, for example, both '/' and '\' are valid path
// separators. Returns NULL if no path separator was found.
const char* FindLastPathSeparator() const;
Expand Down
2 changes: 1 addition & 1 deletion googletest/include/gtest/internal/gtest-internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -1495,7 +1495,7 @@ class NeverThrown {

// Implements Boolean test assertions such as EXPECT_TRUE. expression can be
// either a boolean expression or an AssertionResult. text is a textual
// represenation of expression as it was passed into the EXPECT_TRUE.
// representation of expression as it was passed into the EXPECT_TRUE.
#define GTEST_TEST_BOOLEAN_(expression, text, actual, expected, fail) \
GTEST_AMBIGUOUS_ELSE_BLOCKER_ \
if (const ::testing::AssertionResult gtest_ar_ = \
Expand Down
2 changes: 1 addition & 1 deletion googletest/scripts/release_docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
interlinked wiki files. When we release a new version of
Google Test or Google Mock, we need to branch the wiki files
such that users of a specific version of Google Test/Mock can
look up documenation relevant for that version. This script
look up documentation relevant for that version. This script
automates that process by:
- branching the current wiki pages (which document the
Expand Down
4 changes: 2 additions & 2 deletions googletest/src/gtest-internal-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -1164,13 +1164,13 @@ class StreamingListener : public EmptyTestEventListener {
}

// Note that "event=TestCaseStart" is a wire format and has to remain
// "case" for compatibilty
// "case" for compatibility
void OnTestCaseStart(const TestCase& test_case) override {
SendLn(std::string("event=TestCaseStart&name=") + test_case.name());
}

// Note that "event=TestCaseEnd" is a wire format and has to remain
// "case" for compatibilty
// "case" for compatibility
void OnTestCaseEnd(const TestCase& test_case) override {
SendLn("event=TestCaseEnd&passed=" + FormatBool(test_case.Passed()) +
"&elapsed_time=" + StreamableToString(test_case.elapsed_time()) +
Expand Down
2 changes: 1 addition & 1 deletion googletest/src/gtest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2241,7 +2241,7 @@ void TestResult::RecordProperty(const std::string& xml_element,
if (!ValidateTestProperty(xml_element, test_property)) {
return;
}
internal::MutexLock lock(&test_properites_mutex_);
internal::MutexLock lock(&test_properties_mutex_);
const std::vector<TestProperty>::iterator property_with_matching_key =
std::find_if(test_properties_.begin(), test_properties_.end(),
internal::TestPropertyKeyIs(test_property.key()));
Expand Down
2 changes: 1 addition & 1 deletion googletest/test/googletest-output-test_.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@ auto dynamic_test = (
"BadDynamicFixture1", "TestBase", nullptr, nullptr, __FILE__, __LINE__,
[]() -> testing::Test* { return new DynamicTest<true>; }),

// Register two tests with the same fixture incorrectly by ommiting the
// Register two tests with the same fixture incorrectly by omitting the
// return type.
testing::RegisterTest(
"BadDynamicFixture2", "FixtureBase", nullptr, nullptr, __FILE__,
Expand Down
4 changes: 2 additions & 2 deletions googletest/test/googletest-param-test-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -835,14 +835,14 @@ TEST(MacroNameing, LookupNames) {
}
}

// Check that the expected form of the test suit name actualy exists.
// Check that the expected form of the test suit name actually exists.
EXPECT_NE( //
know_suite_names.find("FortyTwo/MacroNamingTest"),
know_suite_names.end());
EXPECT_NE(
know_suite_names.find("MacroNamingTestNonParametrized"),
know_suite_names.end());
// Check that the expected form of the test name actualy exists.
// Check that the expected form of the test name actually exists.
EXPECT_NE( //
know_test_names.find("FortyTwo/MacroNamingTest.FooSomeTestName/0"),
know_test_names.end());
Expand Down
2 changes: 1 addition & 1 deletion googletest/test/googletest-printers-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ OutputStream& operator<<(OutputStream& os,
return os;
}

// A user-defined streamable but recursivly-defined container type in
// A user-defined streamable but recursively-defined container type in
// a user namespace, it mimics therefore std::filesystem::path or
// boost::filesystem::path.
class PathLike {
Expand Down

0 comments on commit 566fdcc

Please sign in to comment.