Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add automatic_copilot_code_review_enabled parameter to ruleset API #3506

Merged

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Mar 10, 2025

Fixes: #3505.

implemented the parameter as optional , but it's based on supposition.
It's optional https://github.com/orgs/community/discussions/141896#discussioncomment-12489418

Copy link

google-cla bot commented Mar 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mikutas mikutas force-pushed the 3505-automatic_copilot_code_review_enabled branch from fb924b7 to fae98c7 Compare March 10, 2025 10:41
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.21%. Comparing base (56f5036) to head (ba7a77c).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3506   +/-   ##
=======================================
  Coverage   91.21%   91.21%           
=======================================
  Files         182      182           
  Lines       15930    15930           
=======================================
  Hits        14531    14531           
  Misses       1225     1225           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikutas mikutas marked this pull request as ready for review March 12, 2025 01:09
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mikutas!
LGTM.
Merging.

@gmlewis gmlewis merged commit 1282133 into google:master Mar 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automatic_copilot_code_review_enabled parameter to ruleset API
2 participants