-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: checker to prevent other checkers from calling javac methods that changed across JDKs #4026
Comments
This SGTM. I created I'd be happy to review PRs to improve coverage in this area. It might make sense to add additional APIs to This could also potentially be a separate check if not all of the issues have |
(Edited: previously this comment referred to a bad call that looked like it was getting missed but it was due to a The
Yes, as long as it flags issues this is still very useful to us, even if we can't apply the auto-fix. |
I opened #4027 to improve coverage of |
I'm going to close this out now that #4029 has landed, thanks!
I don't have any brilliant ideas for this either, but proposals are welcome if you think of a name that would be clearer. |
Error Prone has run into a couple issues lately where building on JDK 17 caused incompatibility with JDK 11, due to changes in javac APIs:
#3895
#2330
NullAway is running into these exact same issues:
uber/NullAway#779
uber/NullAway#795
It might be nice to have a checker that flags when other checkers are calling the methods whose signatures have changed. Maybe just like the
DoNotCallChecker
but a separate implementation? This way checkers could share knowledge on what calls to avoid moving forward. (This kind of issue will get caught if tests are configured to run on older JDKs, which NullAway does now, but we still missed uber/NullAway#794 due to a lack of unit test coverage.)The text was updated successfully, but these errors were encountered: