Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI (Aarch64, Power) #285

Merged
merged 11 commits into from
Nov 3, 2022
Merged

Improve CI (Aarch64, Power) #285

merged 11 commits into from
Nov 3, 2022

Conversation

Mizux
Copy link
Collaborator

@Mizux Mizux commented Nov 2, 2022

Few updates

  • cleanup scripts
  • Add Aarch64 bootlin support (script, cmake/ci, workflows)
  • Add Power bootlin support (script, cmake/ci, workflows)

@Mizux Mizux requested a review from gchatelet November 2, 2022 10:49
@Mizux Mizux changed the title Mizux/ci Improve CI (Aarch64, Power) Nov 2, 2022
local -r GCC_PREFIX="powerpc64"
;;
"ppc")
#local -r POWER_URL="https://toolchains.bootlin.com/downloads/releases/toolchains/powerpc-e500mc/tarballs/powerpc-e500mc--glibc--stable-2021.11-1.tar.bz2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it commented out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While QEmu provide a single ppc target (as well as docker), bootlin provide several flavors
440fp and e500mc for PowerPC while here I arbitrarily the 440fp we could have choose the other one...

An other way would be to have ppc-e500mc and ppc-440fp (and ppc alias of ppc-440fp ?)

ref:

docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
...
Setting /usr/bin/qemu-ppc-static as binfmt interpreter for ppc
Setting /usr/bin/qemu-ppc64-static as binfmt interpreter for ppc64
Setting /usr/bin/qemu-ppc64le-static as binfmt interpreter for ppc64le

note: same issue with ppc64[le]: power8, e5500, 'e6500', le-power8...

@@ -230,12 +253,14 @@ function expand_codescape_config() {
"mips64")
MIPS_FLAGS="-EB -mips64r6 -mabi=64"
FLAVOUR="mips-r6-hard"
#MIPS_FLAGS="-EB -mips64r2 -mabi=64"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here and below, why do you need to keep these comments?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here maybe we could have a flag to decide which version to use so user can easily reuse this script to target the correct CPU by just changing one line, so while we only enable one flavor it's easy for the community to adapt.

Or again we should/could have both mips-r6/mips-r2 and a mips alias to target the last one aka mips-r6 ?

@gchatelet gchatelet merged commit 16ca56f into main Nov 3, 2022
@gchatelet gchatelet deleted the mizux/ci branch November 3, 2022 09:40
@gchatelet gchatelet added the misc non user facing: internal, cleanup, ci, release process label Apr 27, 2023
@gchatelet gchatelet added this to the v0.8.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc non user facing: internal, cleanup, ci, release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants