Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CMake googletest-download failed #202

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

toor1245
Copy link
Contributor

No description provided.

@toor1245
Copy link
Contributor Author

@Mizux, @gchatelet please review

@Mizux Mizux self-requested a review November 16, 2021 08:19
@Mizux Mizux self-assigned this Nov 16, 2021
@Mizux Mizux merged commit fc52c64 into google:master Nov 16, 2021
@Mizux
Copy link
Collaborator

Mizux commented Nov 16, 2021

Thx !

Maybe we should point to a release instead like v1.11.0
pro: more stable.
cons: increase the technical debt and maintenance cost to bump it from time to time to try to stay up to date.

@Mizux Mizux added bug Something isn't working cmake CMake related issue labels Nov 16, 2021
@Mizux Mizux added this to the v0.7.0 milestone Nov 16, 2021
@toor1245 toor1245 deleted the cmake-googletest-download-fix branch November 16, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmake CMake related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants