Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64-apple-ios-sim triple #484

Merged
merged 2 commits into from
May 7, 2022
Merged

Add aarch64-apple-ios-sim triple #484

merged 2 commits into from
May 7, 2022

Conversation

keith
Copy link
Contributor

@keith keith commented Apr 29, 2022

This triple is used for the arm64 iOS simulator on M1 macs. This
required a cfg-expr update to get this triple added upstream.

This triple is used for the arm64 iOS simulator on M1 macs. This
required a cfg-expr update to get this triple added upstream.
@dfreese
Copy link
Collaborator

dfreese commented May 6, 2022

What's the Min Supported Rust Version (MSRV) on the new version of cfg-if?

This is required for include_str
@keith
Copy link
Contributor Author

keith commented May 6, 2022

It looks like include_str requires 1.54, I've updated CI as such, is that ok?

Copy link
Collaborator

@dfreese dfreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with that.

We're 9+ months out from the July 29, 2021 release of 1.54. cargo-raze doesn't have a clear MSRV policy, but that's significantly less aggressive than when we bumped to 1.45.

@dfreese dfreese merged commit 511a54d into google:main May 7, 2022
@keith
Copy link
Contributor Author

keith commented May 7, 2022

Thanks!

ttiurani pushed a commit to ttiurani/cargo-raze that referenced this pull request Feb 20, 2023
This triple is used for the arm64 iOS simulator on M1 macs. This
required a cfg-expr update to get this triple added upstream.

The MSRV was bumped to 1.54 as cfg-expr began to use 
include_str.  1.54 was released on July 29th, 2021.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants