-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publish-new-version.sh for pushing versions of the crate #217
Conversation
@acmcarther Are there also some examples of using this script? Whenever I add things like this to projects at work, I typically add a block of comments at the top of the file that show simple usage just to make it crystal clear as to what to do. # Use the script like so
# Args: ...docs...
#
# ./my_script.sh arg1 arg2 # Use the script like so
# Environment: ...docs...
#
# ARG_VAR=1 ./my_other_script.sh Things like that. While It's unlikely I'll be doing a deploy for this so If there's some internal Google doc that has this, that works as well. The thing I want to avoid is all maintainers who have familiarity with the project/script being unavailable and therefore no more releases happen because maybe some constraint changed or things are not as obvious to the available/new maintainers. Whether or not you decide to do that, I'm thankful for this PR! 😄 |
Thanks, that's valuable feedback. I've added some documentation about what the script does and how to use it to the top of the file. Incidentally, I've also updated the mechanism it uses to take in the new version from an environment variable to a regular argument. |
@acmcarther When the version is updated should the |
I'm not really sure. I don't consider the contents of That said, this should be a consideration in handling #210 I think. |
As a quick followup. Do you think you could delete some old branches? 😅 |
Done! |
Adds a script for publishing new versions of this crate to codify my shell history into a shell script usable by other folks.
Has some rudimentary checks for the existence of
cargo
and that the working directory is clean.r: @UebelAndre as well