Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tera errors #211

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Improved tera errors #211

merged 1 commit into from
Sep 9, 2020

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Sep 4, 2020

This fixes some annoyingly vague errors:

Error: Raze failed to render with cause: "Failed to render 'templates/remote_crates.bzl.template'

becomes

Error: Raze failed to render with cause: "Failed to render 'templates/remote_crates.bzl.template'
└─Template 'templates/partials/remote_crates_patch.template' not found"

@UebelAndre UebelAndre changed the title Improved tera Improved tera errors Sep 4, 2020
@UebelAndre
Copy link
Collaborator Author

@damienmg Hey, can I get your eyes on this? It's small (and I promise not to add anything to it 😅)

@damienmg
Copy link
Member

damienmg commented Sep 8, 2020

What is the relation between the 3 commits? Shouldn't that be 3 different PRs?

@UebelAndre
Copy link
Collaborator Author

UebelAndre commented Sep 8, 2020

These are all things that I split out of #212 to try and make that more focused. I can split these commits up into different PRs if you prefer but I felt the changes were small enough that they could be bundled into one pull request.

@damienmg
Copy link
Member

damienmg commented Sep 9, 2020

Sorry I realized I haven't answered. We squash all PR into a single commit so they make more sense as separate PR. It is a general approach at Google (and people using Gerrit) to do a code review per logical change (for this PR 1 change = 1 commit) and we tend to reflect this in our projects on github.

Do you mind splitting this into 3 PRs?

@UebelAndre
Copy link
Collaborator Author

@damienmg Sounds good and makes sense.

Done 😄
#213 #214

@damienmg
Copy link
Member

damienmg commented Sep 9, 2020

Thanks!

@damienmg damienmg merged commit c446fbb into google:master Sep 9, 2020
@UebelAndre UebelAndre deleted the improved-tera branch September 9, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants