Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecated objects for kustomize #3653

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iamhalje
Copy link

this PR addresses and fixed deprecated patches and objects in kustomize examples

  1. replaced deprecated patches with the Patches field, which provides a superset of the functionality of PatchesStrategicMerge
  2. removed non-existent patch that was previously causing issues
  3. updated deprecated bases for resources to the correct format
  4. replace deprecated commonLabels to align with the latest best practices

Copy link

google-cla bot commented Jan 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@iamhalje
Copy link
Author

this PR also solve #3603

@iwankgb
Copy link
Collaborator

iwankgb commented Feb 2, 2025

/skip pull-cadvisor-e2e

@iamhalje
Copy link
Author

iamhalje commented Feb 2, 2025

@iwankgb is there anything that needs to be added for PR approval?

@iwankgb
Copy link
Collaborator

iwankgb commented Feb 2, 2025

/skip pull-cadvisor-e2e

@iwankgb
Copy link
Collaborator

iwankgb commented Feb 2, 2025

@iamhalje no and I can't do anything more either.

@iamhalje
Copy link
Author

iamhalje commented Feb 2, 2025

@iwankgb who else should we notify for approval?

I’d love to see projects like this develop further, avoiding deprecated objects and fixing any outstanding issues as we go

@iwankgb
Copy link
Collaborator

iwankgb commented Feb 2, 2025

@dims can you skip this check perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants