Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.11 wheels #984

Closed
alexprengere opened this issue Oct 24, 2022 · 13 comments · Fixed by #987 or google/brotli-wheels#15
Closed

Add 3.11 wheels #984

alexprengere opened this issue Oct 24, 2022 · 13 comments · Fixed by #987 or google/brotli-wheels#15

Comments

@alexprengere
Copy link

As Python3.11 will be released later today, it would be truly great of 3.11 wheels could be added to the latest release.

@sans-c
Copy link

sans-c commented Oct 25, 2022

Yep, right now brotli installation fails with Python 3.11 and pip with default options.

@mhils
Copy link

mhils commented Oct 25, 2022

It would be incredibly useful to provide abi3 wheels, which makes sure that no additional work is needed to support future Python releases: https://cibuildwheel.readthedocs.io/en/stable/faq/#abi3

@fenchu
Copy link

fenchu commented Nov 4, 2022

Wheel installation will fix this deprecation on 3.11/pip23.1:

DEPRECATION: brotli is being installed using the legacy 'setup.py install' method, 
because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 
will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. 
Discussion can be found at https://github.com/pypa/pip/issues/8559

pypa/pip#8559

@cherinyy
Copy link
Contributor

cherinyy commented Nov 8, 2022

DEPRECATION: brotli is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed.

#987

@anthrotype
Copy link
Member

incredibly useful to provide abi3 wheels

indeed, but last time I tried this a couple years ago abi3 wheels would only work for linux or macos, but not for windows. I don't know if anything changed since then, would be worth retrying.

@anthrotype
Copy link
Member

note the brotli's wheels are built from this other repo https://github.com/google/brotli-wheels
it's probably just a matter of adding 3.11 to the build matrix and cibuildwheel should do the rest.
I'll take a look

@mhils
Copy link

mhils commented Nov 15, 2022

Anecdata: We've successfully shipped abi3 wheels for Windows, Linux and macOS about a month ago. It looks like everything works pretty flawlessly nowadays. 🙌

Here's an example conversion for aioquic I did a week ago: aiortc/aioquic@main...mhils:aioquic:abi3
(CI: https://github.com/mhils/aioquic/actions/runs/3406468326)

anthrotype added a commit to google/brotli-wheels that referenced this issue Nov 15, 2022
@alexprengere
Copy link
Author

I think this was closed by mistake @eustas.
#987 only fixes an issue reported as a comment here, not the original issue of the missing wheels (see here), which would need google/brotli-wheels#15.

@eustas
Copy link
Collaborator

eustas commented Nov 16, 2022

Agree. That was auto-close because of "fix #xxx" in description

@eustas eustas reopened this Nov 16, 2022
@anthrotype
Copy link
Member

I built the python 3.11 wheels in google/brotli-wheels#15 and can upload them manually using twine to PyPI, like I did for 3.10 wheels a year ago.
If @eustas cuts a new Brotli release, I can also update brotli-wheels repository to point to the latest git tag and new wheels can be built. Last tag was 2 years ago.

@anthrotype
Copy link
Member

Regarding abi3 wheels I suggest you file a separate issue. I can't work on it right now, but found this interesting article https://blog.trailofbits.com/2022/11/15/python-wheels-abi-abi3audit/

@anthrotype
Copy link
Member

I just uploaded the wheels for CPython 3.11 for linux, mac and windows at https://pypi.org/project/Brotli/1.0.9/#files so this can be closed

@alexprengere
Copy link
Author

I confirm the wheels are up there, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants