Avoid using harcoded HO port values. #890
Open
+31
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ser-io
requested review from
Databean,
jemoreira,
rmuthiah,
jmacnak and
adelva1984
as code owners
ser-io
force-pushed
the
fixed-port
branch
2 times, most recently
from
a240408 to
7a81643
Compare
jemoreira
approved these changes
Feb 28, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
| result.DockerContainerID = id | ||
| result.ServiceURL = fmt.Sprintf("http://0.0.0.0:%d", port) | ||
| result.ServiceURL = fmt.Sprintf("http://%s:2080", ipAddr) |
There was a problem hiding this comment.
The docker image used in the e2e tests have the HO running at 2080 and we don't have logic in place to update the container and change the HO port.
I used a const for the value though.
Comment on lines
142
to
151
| var found *types.Container | ||
| for _, container := range listRes { | ||
| if container.ID == id { | ||
| found = &container | ||
| break | ||
| } | ||
| } | ||
| if found == nil { | ||
| return "", fmt.Errorf("container not found: %q", id) | ||
| } |
There was a problem hiding this comment.
Instead of looping over all containers here, could the client have a ContainerById method instead?
There was a problem hiding this comment.
Good call, used ContainerInspect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.