Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure com_google_api's service protos are correctly built #9

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

davemasselink
Copy link
Contributor

@davemasselink davemasselink commented Jun 27, 2023

Add a test case for exercising ES6 generation of proto files using the extend keyword.

Builds on work in protobuf-javascript repo: PR#8

@egormodin
Copy link
Collaborator

isn't it correctly build now, so nothing is failed? would it be better to simulate a case where we are failed. I mean create proto which using extend feature and create a ts test case where it is being used.

@davemasselink
Copy link
Contributor Author

yes, I think you're right

initially I thought the issue might come up in puling in much of the same dependency chain but as you say, that doesn't highlight the issue

creating a new proto using extend keyword to test now

@gonzojive gonzojive self-assigned this Jul 6, 2023
@davemasselink
Copy link
Contributor Author

ready for your to merge, if and when you feel comfortable doing so, @gonzojive. thanks

@reddaly reddaly merged commit 316519e into gonzojive:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants