-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
microsoft: added DeviceAuthURL to AzureADEndpoint #701
microsoft: added DeviceAuthURL to AzureADEndpoint #701
Conversation
The Microsoft identity platform supports the device authorization grant: https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-device-code This PR adds the "https://login.microsoftonline.com/{tenant}/oauth2/v2.0/devicecode" DeviceAuthURL to the AzureADEndpoint.
This PR (HEAD: f7cd8ae) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/564315. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Enrico Candino: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Matt Hickford: Patch Set 2: Code-Review+2 Commit-Queue+1 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-05T14:23:33Z","revision":"fa75c079008b12253435dc94aecc50b739007ecf"} Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Matt Hickford: Patch Set 2: -Code-Review (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
This PR (HEAD: 2b953c3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/564315. Important tips:
|
Message from Matt Hickford: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Enrico Candino: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Matt Hickford: Patch Set 3: Code-Review+2 Commit-Queue+1 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-05T15:59:51Z","revision":"ffcb78f68d3083ae14a0e8db7c4de0ce9efa9b40"} Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Matt Hickford: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Dmitri Shuralyov: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
Message from Than McIntosh: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564315. |
The Microsoft identity platform supports the device authorization grant: https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-device-code This PR adds the "https://login.microsoftonline.com/{tenant}/oauth2/v2.0/devicecode" DeviceAuthURL to the AzureADEndpoint. Fixes #700 Change-Id: I8ca571391e0e0f4d383e3f2f07a66b26edcb4679 GitHub-Last-Rev: 2b953c3 GitHub-Pull-Request: #701 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/564315 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Matt Hickford <matt.hickford@gmail.com> Run-TryBot: Matt Hickford <matt.hickford@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This PR is being closed because golang.org/cl/564315 has been merged. |
The Microsoft identity platform supports the device authorization grant: https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-device-code This PR adds the "https://login.microsoftonline.com/{tenant}/oauth2/v2.0/devicecode" DeviceAuthURL to the AzureADEndpoint. Fixes golang#700 Change-Id: I8ca571391e0e0f4d383e3f2f07a66b26edcb4679 GitHub-Last-Rev: 2b953c3 GitHub-Pull-Request: golang#701 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/564315 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Matt Hickford <matt.hickford@gmail.com> Run-TryBot: Matt Hickford <matt.hickford@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The Microsoft identity platform supports the device authorization grant:
https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-device-code
This PR adds the "https://login.microsoftonline.com/{tenant}/oauth2/v2.0/devicecode" DeviceAuthURL to the AzureADEndpoint.
Fixes #700