Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: update helperNames just before checking it #45071

Closed
wants to merge 2 commits into from
Closed

testing: update helperNames just before checking it #45071

wants to merge 2 commits into from

Conversation

qingyunha
Copy link
Contributor

@qingyunha qingyunha commented Mar 17, 2021 •
edited
Loading

parent's helperNames has not been set when frameSkip called, moving
helperNames initilazing to frameSkip.

Fixes #44887

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 17, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: b00dcf0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/302469 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: b49843a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/302469 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from 陶青云:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 8f3c2bc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/302469 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 4: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1c38286d

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@qingyunha
testing: update helperNames just before checking it
2ed2b81 
parent's helperNames has not been set when frameSkip called, moving
helperNames initilazing to frameSkip.

Fixes golang#44887
@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4:

Build is still in progress...
This change failed on openbsd-amd64-68:
See https://storage.googleapis.com/go-build-log/1c38286d/openbsd-amd64-68_d2c3b023.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 2ed2b81) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/302469 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@qingyunha qingyunha changed the title testing: fix Helper line number change testing: update helperNames just before checking it Mar 17, 2021
@gopherbot
Copy link
Contributor

Message from 陶青云:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=8ad3109a

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 7: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 7: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan Boreham:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@qingyunha
testing: update helperNames just before checking it
44b90b2 
parent's helperNames has not been set when frameSkip called, moving
helperNames initilazing to frameSkip.

Fixes golang#44887
@gopherbot
Copy link
Contributor

This PR (HEAD: 44b90b2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/302469 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from 陶青云:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cherry Zhang:

Patch Set 8: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 8: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 8:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=7aa0be4f

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 8: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/302469.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 19, 2021
@qingyunha @ianlancetaylor
testing: update helperNames just before checking it
6704843 
parent's helperNames has not been set when frameSkip called, moving
helperNames initilazing to frameSkip.

Fixes #44887

Change-Id: I5107c5951033e5e47d1ac441eac3ba5344a7bdc0
GitHub-Last-Rev: 44b90b2
GitHub-Pull-Request: #45071
Reviewed-on: https://go-review.googlesource.com/c/go/+/302469
Trust: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
gopherbot pushed a commit that referenced this pull request Mar 24, 2021
@qingyunha @ianlancetaylor
[release-branch.go1.16] testing: update helperNames just before check…
902d16e 
…ing it

parent's helperNames has not been set when frameSkip called, moving
helperNames initilazing to frameSkip.

For #44887
Fixes #44888

Change-Id: I5107c5951033e5e47d1ac441eac3ba5344a7bdc0
GitHub-Last-Rev: 44b90b2
GitHub-Pull-Request: #45071
Reviewed-on: https://go-review.googlesource.com/c/go/+/302469
Trust: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit 6704843)
Reviewed-on: https://go-review.googlesource.com/c/go/+/303189
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
@odeke-em
Copy link
Member

This PR somehow wasn't closed after CL https://go-review.googlesource.com/c/go/+/302469 got merged. Kindly ccing @dmitshur @cagedmantis @toothrot, and then I shall close it.

@odeke-em odeke-em closed this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testing: Helper line number has changed in 1.16
3 participants
@qingyunha @gopherbot @odeke-em