Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vuln: Unclear how to request standard-library vulnerabilities be added to DB #54985

Closed
rkennedy opened this issue Sep 9, 2022 · 4 comments
Closed
Assignees
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone

Comments

@rkennedy
Copy link

rkennedy commented Sep 9, 2022

What did you do?

The release announcement for Go 1.19.1 mentions two vulnerabilities, one in net/http and the other in net/url. They're obviously public, but as far as I can tell, those vulnerabilities are not present in golang/vulndb. They're not specifically excluded, either.

$ git remote -v
origin  https://github.com/golang/vulndb.git (fetch)
origin  https://github.com/golang/vulndb.git (push)
$ git rev-parse HEAD
3859e52b1385c13b76efe662bcf02c80beda4321
$ git grep -i 'CVE-2022-27664|CVE-2022-32190'
$

They are vulnerabilities, though, aren't they? Or is there some nuance to the definition that I've missed?

The form for submitting additional vulnerabilities says it's for public vulnerabilities that are "not maintained by the Go Team." What's the process for adding vulnerabilities to the database that are maintained by the Go Team?

What did you expect to see?

I expected to see the known vulnerabilities accounted for in the database already, or else I expected to see some instructions about how to get Go-Team-managed vulnerabilities into vulndb.

What did you see instead?

I only see instructions about other vulnerabilities

Among the open issues for vulndb, I see ones for vulnerabilities in the standard library (including one for CVE-2022-27664). Does that mean someone misused the submission form, or what?

@rkennedy rkennedy added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 9, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 9, 2022
@seankhliao
Copy link
Member

cc @golang/vulndb

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/430356 mentions this issue: .github/ISSUE_TEMPLATE: add template for missing cve/ghsa

gopherbot pushed a commit to golang/vulndb that referenced this issue Sep 12, 2022
For golang/go#54985

Change-Id: I26bdbe1291b15033553dfd2f367c57daea174421
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/430356
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
Reviewed-by: Julie Qiu <julieqiu@google.com>
@tatianab
Copy link

Hi Rob, thanks for the report! These two vulnerabilities should definitely be in the database. We will add them today.

For future reference, there is now a lightweight way to tell us about a missing CVE or GHSA: https://go.dev/s/vulndb-missing-cve

@rkennedy
Copy link
Author

That new form looks just right. Thanks for adding it!

@golang golang locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Development

No branches or pull requests

5 participants