Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: scope is unset on receivers of instantiated methods #51920

Closed
findleyr opened this issue Mar 24, 2022 · 4 comments
Closed

go/types, types2: scope is unset on receivers of instantiated methods #51920

findleyr opened this issue Mar 24, 2022 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.19

Comments

@findleyr
Copy link
Member

While prototyping #51682, I observed that while substituting in method receivers we do not set the parent scope.

This is unintended, and should probably be fixed for 1.18.1.

CC @griesemer
@griesemer griesemer added this to the Go1.18.1 milestone Mar 24, 2022
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 24, 2022
@findleyr findleyr self-assigned this Mar 24, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/395538 mentions this issue: go/types, types2: preserve parent scope when substituting receivers

@findleyr
Copy link
Member Author

@gopherbot please consider this for backport to 1.18, it is an oversight.

@gopherbot gopherbot mentioned this issue Mar 29, 2022
Closed
@gopherbot
Copy link
Contributor

Backport issue(s) opened: #52007 (for 1.18).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/395680 mentions this issue: [release-branch.go1.18] go/types, types2: preserve parent scope when substituting receivers

gopherbot pushed a commit that referenced this issue Apr 4, 2022
@findleyr @cherrymui
[release-branch.go1.18] go/types, types2: preserve parent scope when …
6412231 
…substituting receivers

For #51920
Fixes #52007

Change-Id: I29e44a52dabee5c09e1761f9ec8fb2e8795f8901
Reviewed-on: https://go-review.googlesource.com/c/go/+/395538
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9b90838)
Reviewed-on: https://go-review.googlesource.com/c/go/+/395680
@cherrymui cherrymui modified the milestones: Go1.18.1, Go1.19 Apr 4, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
4 participants
@griesemer @gopherbot @cherrymui @findleyr