Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database/gdb): set node.Link to an empty string #4118

Closed
wants to merge 2 commits into from

Conversation

lleo126
Copy link

@lleo126 lleo126 commented Jan 14, 2025

set node.Link to an empty string in parseConfigNodeLink function

…eConfigNodeLink` function for consistent handling of link configurations
@lleo126
Copy link
Author

lleo126 commented Jan 14, 2025

this problem is caused by PR4058

@gqcn
Copy link
Member

gqcn commented Jan 22, 2025

@lleo126 Hello, why should you empty the link configuration?

@lleo126
Copy link
Author

lleo126 commented Jan 22, 2025

@lleo126 Hello, why should you empty the link configuration?

@gqcn Due to #4058, note.link = "" was accidentally deleted, causing the database connection configured in link mode to fail.

gf v2.8.3 其中 note.link = "" 被误删,导致走到configNodeToSource的已废弃分支,致使link方式配置的数据库连接失效

@gqcn
Copy link
Member

gqcn commented Feb 14, 2025

@lleo126 Hello, why should you empty the link configuration?

@gqcn Due to #4058, note.link = "" was accidentally deleted, causing the database connection configured in link mode to fail.

gf v2.8.3 其中 note.link = "" 被误删,导致走到configNodeToSource的已废弃分支,致使link方式配置的数据库连接失效

目前看link配置项是生效的,有复现代码吗?或者提交对应单测验证一下呢?

@houseme houseme requested a review from Copilot March 28, 2025 05:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue in the gdb configuration by ensuring that the Link property of a node is explicitly set to an empty string.

  • Bug fix: Ensures node.Link is cleared in the parseConfigNodeLink function.

@gqcn gqcn added the closed due to none activity Closed due to it has no activity for too long. label Apr 1, 2025
@gqcn gqcn closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed due to none activity Closed due to it has no activity for too long.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants