testnet_v1: add bridged-token-list.json with UAN #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
Flouse
reviewed
Jul 16, 2022
testnet_v1_1/bridged-token-list.json
Outdated
| "UAN": "ETH.gw|gb.ckb|fb.eth", | ||
| "displayName": "ETH (via ForceBridge from ETH)" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Okay, but what is the reason of doing this?
There was a problem hiding this comment.
If content is added to the end of the file, then the line that was previously the last line will have been edited to include a newline character. This means that blame ing the file to find out when that line was last edited will show the text addition, not the commit before that you actually wanted to see.
see: https://stackoverflow.com/a/729795/7365437
You can configure your editor to do this automatically.
Check-list
|
Flouse
approved these changes
Jul 16, 2022
ShookLyngs
changed the title
chore: add a newline at the end of file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR was closed mistakenly:
These are the bridged tokens on Godwoken testnet_v1.
I have referenced with these files, please correct me if my commited info is wrong: