C#: Update Basis Euler angle code to match core #66387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
cs-basis-euler
branch
from
6ebff54 to
fe71353
Compare
raulsntos
reviewed
Sep 30, 2022
neikeq
approved these changes
Sep 30, 2022
neikeq
reviewed
Oct 2, 2022
| YZX, | ||
| ZXY, | ||
| ZYX | ||
| }; |
There was a problem hiding this comment.
Is this used anywhere outside Basis? If not, we may want to move it inside the Basis struct, like Vector3.Axis.
There was a problem hiding this comment.
The same values are used in Node3D already, but I don't think it's typed as the enum (just int). Also, the plan is to use it in Quaternion soon, see #66747 and https://github.com/aaronfranke/godot/tree/quat-euler-order
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the changes in #54084 to C#. It also solves #66268. I did some testing with these changes applied to 3.x using the test code in the OP and the output is correct.