Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI step for compiling and testing godot-cpp #54015

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

BastiaanOlij
Copy link
Contributor

@BastiaanOlij BastiaanOlij commented Oct 20, 2021

Adding CI steps here to check if the changes result in a compile-able godot-cpp.
We do this by extracting a new extension_api.json file and attempting to compile godot-cpp with it.

We'll stick to compiling everything for now, once Godot is stable we'll look into checking if we have problematic edits in the extension_api.json file and maybe see about a test extension we can actually run in CI.

@akien-mga akien-mga added this to the 4.0 milestone Oct 20, 2021
@BastiaanOlij BastiaanOlij force-pushed the godot-cpp-ci branch 2 times, most recently from 4617764 to b36e002 Compare October 20, 2021 09:59
@BastiaanOlij BastiaanOlij force-pushed the godot-cpp-ci branch 3 times, most recently from 523cba4 to 9060829 Compare October 20, 2021 11:47
@BastiaanOlij BastiaanOlij marked this pull request as ready for review October 20, 2021 11:49
@BastiaanOlij BastiaanOlij requested a review from a team as a code owner October 20, 2021 11:49
@akien-mga
Copy link
Member

It seems to stall on "Check for extension api updates", no idea why.

@fire
Copy link
Member

fire commented Oct 20, 2021

Maybe try ${{ matrix.bin }} --headless --dump-extension-api 2>&1 > /dev/null || true

@akien-mga
Copy link
Member

akien-mga commented Oct 20, 2021

Maybe try ${{ matrix.bin }} --headless --dump-extension-api 2>&1 > /dev/null || true

Yes, and then the whole shebang to use a software Vulkan renderer and xvfb is not needed.

I don't think it will solve the issue though, @qarmin seems to have the same issue on #47600 (comment)

@BastiaanOlij
Copy link
Contributor Author

thats weird, it ran the last time, wonder why it stopped this time

@BastiaanOlij
Copy link
Contributor Author

Maybe try ${{ matrix.bin }} --headless --dump-extension-api 2>&1 > /dev/null || true

This gives a display error, weird...

@BastiaanOlij
Copy link
Contributor Author

BastiaanOlij commented Oct 21, 2021

@akien-mga I'm stuck, it again just stalled on executing the dump, I went back to running it with swift shader, running it headless I got a display ID error.

The time it worked I had an ls after running it. I'm going to try one more thing, re-ordering what I'm doing so I can combine the copy commands. Maybe because we're not giving any output it gets stuck on that.

edit ok, I'm now checking out godot-cpp before building the extension api and calling a python script that doesn't do anything afterwards.
That script we can later on use to compare the old and new api.

@BastiaanOlij BastiaanOlij force-pushed the godot-cpp-ci branch 3 times, most recently from c96153f to f010d9c Compare October 21, 2021 08:51
@akien-mga
Copy link
Member

Now building fine 👍

It adds ~7 min to the build, we'll want to look into having caching for the godot-cpp build too to speed this up on incremental rebuilds.

@akien-mga akien-mga merged commit 9c9ec63 into godotengine:master Oct 21, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants