AnimationTree parameter overhaul #53691
Draft
+409
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
reviewed
Oct 12, 2021
|
|
||
| if (transition_lines[i].mode != state_machine->get_transition(tidx)->get_switch_mode()) { | ||
| state_machine_draw->update(); | ||
| break; | ||
| } | ||
|
|
||
| bool acstate = transition_lines[i].advance_condition_name != StringName() && bool(AnimationTreeEditor::get_singleton()->get_tree()->get(AnimationTreeEditor::get_singleton()->get_base_path() + String(transition_lines[i].advance_condition_name))); | ||
| //bool acstate = transition_lines[i].advance_condition_name != StringName() && bool(AnimationTreeEditor::get_singleton()->get_tree()->get(AnimationTreeEditor::get_singleton()->get_base_path() + String(transition_lines[i].advance_condition_name))); |
There was a problem hiding this comment.
Code that is not used should be deleted.
There was a problem hiding this comment.
Yeah, mostly just keeping it there is a pseudo todo, since I'm still very heavily figuring out how to adapt everything to the new system
SaracenOne
force-pushed
the
animation_tree_parameter_overhaul
branch
from
060e1be to
cc14193
Compare
…ed custom_parameters
…r, as well as naming their displays in the nodes themselves.
…tionNodes. Rename VariantType to Parameter type and place in AnimationNode. Fix Parameter type enum definition. Change advance comparison value property when parameter type is changed.
SaracenOne
force-pushed
the
animation_tree_parameter_overhaul
branch
from
755e3cc to
18587e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing draft implementation on migrating AnimationTree's parameter system to be able to support a blackboard style approach to parameter assignment and reuse. More details can be found in the proposal here (godotengine/godot-proposals#3352)