Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Add OS.get_external_data_dir() to get Android external directory #49436

Merged
merged 1 commit into from
Jun 10, 2021
Merged

[3.x] Add OS.get_external_data_dir() to get Android external directory #49436

merged 1 commit into from
Jun 10, 2021

Conversation

madmiraal
Copy link
Contributor

3.x version of #49435.

@madmiraal madmiraal added this to the 3.4 milestone Jun 8, 2021
@madmiraal madmiraal requested review from a team as code owners June 8, 2021 18:30
m4gr3d
m4gr3d requested changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Same feedback as for #49435

@madmiraal madmiraal force-pushed the add-android-external-dir-3.x branch from 2fbbbc2 to 6d63ccb Compare June 10, 2021 15:48
@akien-mga akien-mga merged commit c7c9335 into godotengine:3.x Jun 10, 2021
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the add-android-external-dir-3.x branch June 11, 2021 08:13
@m4gr3d m4gr3d mentioned this pull request Jul 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
bug enhancement platform:android topic:core
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@madmiraal @akien-mga @m4gr3d