[FBX] crashing due to parser error 'GetRequiredElement' is not gracefully failing

[duasun]

Godot version:
Godot 3.2.4. beta 3 (and beta 2)

OS/device including version:
GLES 3, Win 10, gtx 1660 super

Issue description:
After drag and drop *.fbx file, editor crashes. It crashes after trying to reload project. I have to manually delete file from project to be able to load project again.

Steps to reproduce:
Drag and drop fbx file (Kenney Assets)

Minimal reproduction project:
Godot issue.zip

[qarmin]

[1] /lib/x86_64-linux-gnu/libc.so.6(+0x46210) [0x7f0479cf1210] (??:0)
[2] FBXDocParser::Element::KeyToken() const (/mnt/Miecz/godot3.2/modules/fbx/fbx_parser/FBXParser.h:127)
[3] FBXDocParser::GetRequiredElement(FBXDocParser::Scope*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, FBXDocParser::Element*) (/mnt/Miecz/godot3.2/modules/fbx/fbx_parser/FBXParser.cpp:1191)
[4] FBXDocParser::MeshGeometry::MeshGeometry(unsigned long, FBXDocParser::Element*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, FBXDocParser::Document const&) (/mnt/Miecz/godot3.2/modules/fbx/fbx_parser/FBXMeshGeometry.cpp:186)
[5] FBXDocParser::LazyObject::LoadObject() (/mnt/Miecz/godot3.2/modules/fbx/fbx_parser/FBXDocument.cpp:159 (discriminator 3))
[6] FBXDocParser::Connection::SourceObject() const (/mnt/Miecz/godot3.2/modules/fbx/fbx_parser/FBXDocument.cpp:690)
[7] FBXDocParser::Model::ResolveLinks(FBXDocParser::Element*, FBXDocParser::Document const&) (/mnt/Miecz/godot3.2/modules/fbx/fbx_parser/FBXModel.cpp:138)
[8] FBXDocParser::Model::Model(unsigned long, FBXDocParser::Element*, FBXDocParser::Document const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (/mnt/Miecz/godot3.2/modules/fbx/fbx_parser/FBXModel.cpp:103)
[9] FBXDocParser::LazyObject::LoadObject() (/mnt/Miecz/godot3.2/modules/fbx/fbx_parser/FBXDocument.cpp:203 (discriminator 3))
[10] FBXDocParser::Connection::SourceObject() const (/mnt/Miecz/godot3.2/modules/fbx/fbx_parser/FBXDocument.cpp:690)
[11] EditorSceneImporterFBX::BuildDocumentBones(Ref<FBXBone>, ImportState&, FBXDocParser::Document const*, unsigned long) (/mnt/Miecz/godot3.2/modules/fbx/editor_scene_importer_fbx.cpp:1251)
[12] EditorSceneImporterFBX::_generate_scene(String const&, FBXDocParser::Document const*, unsigned int, int, int) (/mnt/Miecz/godot3.2/modules/fbx/editor_scene_importer_fbx.cpp:378 (discriminator 2))
[13] EditorSceneImporterFBX::import_scene(String const&, unsigned int, int, List<String, DefaultAllocator>*, Error*) (/mnt/Miecz/godot3.2/modules/fbx/editor_scene_importer_fbx.cpp:154)
[14] ResourceImporterScene::import(String const&, String const&, Map<StringName, Variant, Comparator<StringName>, DefaultAllocator> const&, List<String, DefaultAllocator>*, List<String, DefaultAllocator>*, Variant*) (/mnt/Miecz/godot3.2/editor/import/resource_importer_scene.cpp:1320)
[15] EditorFileSystem::_reimport_file(String const&) (/mnt/Miecz/godot3.2/editor/editor_file_system.cpp:1798)
[16] EditorFileSystem::reimport_files(Vector<String> const&) (/mnt/Miecz/godot3.2/editor/editor_file_system.cpp:1994 (discriminator 3))
[17] EditorFileSystem::_update_scan_actions() (/mnt/Miecz/godot3.2/editor/editor_file_system.cpp:592)
[18] EditorFileSystem::_notification(int) (/mnt/Miecz/godot3.2/editor/editor_file_system.cpp:1175)
[19] EditorFileSystem::_notificationv(int, bool) (/mnt/Miecz/godot3.2/editor/editor_file_system.h:108 (discriminator 14))
[20] Object::notification(int, bool) (/mnt/Miecz/godot3.2/core/object.cpp:931)
[21] SceneTree::_notify_group_pause(StringName const&, int) (/mnt/Miecz/godot3.2/scene/main/scene_tree.cpp:985)
[22] SceneTree::idle(float) (/mnt/Miecz/godot3.2/scene/main/scene_tree.cpp:525 (discriminator 3))
[23] Main::iteration() (/mnt/Miecz/godot3.2/main/main.cpp:2103)
[24] OS_X11::run() (/mnt/Miecz/godot3.2/platform/x11/os_x11.cpp:3410)
[25] godot(main+0x125) [0x138258b] (/mnt/Miecz/godot3.2/platform/x11/godot_x11.cpp:57)
[26] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7f0479cd20b3] (??:0)
[27] godot(_start+0x2e) [0x13823ae] (??:?)

[JotaFaD]

Also happens on RTX 2060, Nvidia driver 457.30, GLES 3.0, Windows 10 2004

[RevoluPowered]

[doc] fbx header: ; FBX 7.3.0 project file <- this file is far too old to be supported.

Can you please let me know where you're exporting this file from?

[RevoluPowered]

Please export in a version like: 2016, 2018 or 2020, not in 2013.

https://help.autodesk.com/view/FBX/2017/ENU/?guid=__files_GUID_A753EE31_7DCF_409E_9270_CD2578FFB633_htm

[RevoluPowered]

Added some safety to the check which crashed.

I'd really like to know where this file is from? / which application / which version it is?

The vendor is entirely missing from the FBX itself.

[duasun]

Its in the kenney asset pack. Free download from web.

…

On Mon, Dec 14, 2020, 18:26 Gordon MacPherson ***@***.***> wrote: Added some safety to the check which crashed. [image: image] <https://user-images.githubusercontent.com/748770/102113768-54164f80-3e31-11eb-81b4-ea321ec53c2f.png> I'd really like to know where this file is from? / which application / which version it is? The vendor is entirely missing from the FBX itself. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#43949 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJJ33WYRYSTCCL6K7ZYPCZTSUZDF3ANCNFSM4UGK23UQ> .

[RevoluPowered]

Its in the kenney asset pack. Free download from web.

OK, do you know what they used to actually make the asset in?

I've already fixed the crash and it seems to load, but would be better if you could tell me this?

[RevoluPowered]

Fix is up, we will close this once its merged thank you for reporting the problem.

[duasun]

https://kenney.nl/assets I am not sure in what software they made it. <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> Virus-free. www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

…

On Mon, Dec 14, 2020 at 6:42 PM Gordon MacPherson ***@***.***> wrote: Fix is up, we will close this once its merged thank you for reporting the problem. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#43949 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJJ33WZZNTBBSRQ32HZBCETSUZFBJANCNFSM4UGK23UQ> .

-- Bojan Damnjanovic, www.stolarskaradionica.com

[akien-mga]

Fixed by #44371.