cpp/capi.cpp: fix ImageProvider leak #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoImageProvider had a memory leak where it got a pointer to a QImage, and never freed it. Qt already has a refcounting system in place so every QImage is actually a pointer to pixel data, but it relies on the destructor for every QImage instance to be called.
niemeyer
added a commit
that referenced
this pull request
Aug 20, 2014
Fix ImageProvider data leak in C++ logic. Fix by Carlos Castillo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoImageProvider had a memory leak where it got a pointer to a QImage,
and never freed it. Qt already has a refcounting system in place so every
QImage is actually a pointer to pixel data, but it relies on the destructor
for every QImage instance to be called.