Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Nil pointer dereference in Arabic translations #1390

Closed
wants to merge 2 commits into from

Conversation

BlackSud0
Copy link
Contributor

Fixes and Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

Description

This PR fixes [Bug #1385]: Nil pointer dereference in Arabic translations and adds comprehensive Arabic (ar) translations for the go-playground/validator package. The implementation provides Arabic error messages for all common validation tags, making the validator more valuable to Arabic-speaking developers.

Features

  • Fixes nil pointer dereference bug in Arabic translations
  • Complete Arabic translations for all standard validation tags
  • Comprehensive test suite to verify translation accuracy
  • Follows the same pattern as existing language translations
  • Properly handles Arabic text direction and grammar

Implementation Details

  • The implementation follows the established pattern in the validator package:
  • Registers translations for each validation tag
  • Provides appropriate Arabic phrasing for validation errors
  • Handles parameter substitution in error messages
  • Includes tests for all validation scenarios

Testing

  • A comprehensive test suite is included that verifies:
  • Basic validations (required, email, etc.)
  • Length validations (min, max, len)
  • Comparison validations (lt, lte, gt, gte, eq, ne)
  • Field comparison validations (eqfield, nefield, gtefield)
  • Content validations (alpha, alphanum, contains, etc.)
  • Special validations (oneof, datetime)
  • All tests pass and confirm that the translations are correctly applied.

Usage Example

validate := validator.New()
arabic := ar.New()
uni := ut.New(arabic, arabic)
trans, _ := uni.GetTranslator("ar")

// Register Arabic translations
ar.RegisterDefaultTranslations(validate, trans)

// Now validation errors will be in Arabic
err := validate.Struct(myStruct)
if err != nil {
    errs := err.(validator.ValidationErrors)
    for _, e := range errs {
        // This will be in Arabic
        fmt.Println(e.Translate(trans))
    }
}

@nodivbyzero
@go-playground/validator-maintainers

@BlackSud0 BlackSud0 requested a review from a team as a code owner February 28, 2025 02:14
@BlackSud0 BlackSud0 closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant