Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add german translations #1322

Merged

Conversation

max-weis
Copy link
Contributor

Fixes Or Enhances

Added German translations for the validation messages. Implemented tests to cover the changes.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@max-weis max-weis requested a review from a team as a code owner September 29, 2024 10:33
@coveralls
Copy link

coveralls commented Sep 29, 2024

Coverage Status

coverage: 75.008% (+0.7%) from 74.292%
when pulling 7ed0232 on max-weis:feature/german-translations
into f1939ee on go-playground:master.

@nodivbyzero
Copy link
Contributor

Overall, it looks good to me.
I just have one question regarding the commented code in this PR.

@nodivbyzero nodivbyzero merged commit 09c1323 into go-playground:master Mar 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants