Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Random(), RandomSeed() and RandomGaussian() #26

Merged
merged 7 commits into from
Jan 10, 2021
Merged

Add Random(), RandomSeed() and RandomGaussian() #26

merged 7 commits into from
Jan 10, 2021

Conversation

psampaz
Copy link
Contributor

@psampaz psampaz commented Jan 10, 2021

Closes #25

@codecov
Copy link

codecov bot commented Jan 10, 2021 •
edited
Loading

Codecov Report

Merging #26 (a77925e) into main (78c452d) will decrease coverage by 0.21%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   73.00%   72.79%   -0.22%     
==========================================
  Files           9        9              
  Lines         515      522       +7     
==========================================
+ Hits          376      380       +4     
- Misses        119      122       +3     
  Partials       20       20
Impacted Files Coverage Δ
api.go 70.00% <0.00%> (-12.36%) ⬇️
proc.go 49.41% <100.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c452d...a77925e. Read the comment docs.

sbinet
sbinet reviewed Jan 10, 2021
View reviewed changes
Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments.

see below.

also: could you remove api_shapes.png and api_shapes_bezier.png from the PR?
I don't think they're needed.

@psampaz psampaz changed the title Random() and RandomSeed() Add Random(), RandomSeed() and RandomGaussian() Jan 10, 2021
@psampaz psampaz changed the title Add Random(), RandomSeed() and RandomGaussian() [WIP]Add Random(), RandomSeed() and RandomGaussian() Jan 10, 2021
sbinet
sbinet reviewed Jan 10, 2021
View reviewed changes
@psampaz psampaz changed the title [WIP]Add Random(), RandomSeed() and RandomGaussian() Add Random(), RandomSeed() and RandomGaussian() Jan 10, 2021
sbinet
sbinet reviewed Jan 10, 2021
View reviewed changes
Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

one last round of nit picks, and we're good to go.

@psampaz psampaz requested a review from sbinet January 10, 2021 17:46
sbinet
sbinet approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

thanks again.

@sbinet sbinet merged commit 06cd9c7 into go-p5:main Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbinet sbinet sbinet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Random(), RandomSeed() and RandomGaussian()
2 participants
@psampaz @sbinet