Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some user name usages #33689

Merged
merged 2 commits into from
Feb 23, 2025
Merged

Fix some user name usages #33689

merged 2 commits into from
Feb 23, 2025
+125 −92

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Feb 23, 2025 •
edited
Loading

  1. GetUserOrgsList should "order by" lower_name
  2. GetIssuePostersWithSearch should search in-case-sensitive-ly
  3. LoginName should not be used as username

By the way, remove unnecessary "onGiteaRun": https://github.com/go-gitea/gitea/pull/33689/files?diff=unified&w=1

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 23, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Feb 23, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 23, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 23, 2025 12:08
@wxiaoguang wxiaoguang merged commit 8ae46d9 into go-gitea:main Feb 23, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 23, 2025
@wxiaoguang wxiaoguang deleted the fix-username branch February 23, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @lafriks @GiteaBot