Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the Layout of the Top Toolbar on the Issues Page #33667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kerwin612
Copy link
Member

before:
570ffee34fbc0c3c3d8998ee0c2df41

after:
21f1b350cc01bb555435a7101188c1c

On the list page, labels and milestones do not serve as a switch-tab. Instead, they function as page navigation. The switch-tab is only appropriate for use on the labels and milestones pages, just like this:
f5f4dfb7b4484c1ea043b6190c394bf

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 21, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 21, 2025
@lunny
Copy link
Member

lunny commented Feb 21, 2025

What's the reason to change the labels and milestones's positions?

@kerwin612
Copy link
Member Author

What's the reason to change the labels and milestones's positions?

As I described, on the default issue list page, labels and milestones do not fall under the functional definition of the switch-tab type. Instead, they serve as a page navigation function.
So, the first step is to change the current switch-tab into the buttons.
After switching to buttons, you will notice that with buttons both in front of and behind an input box, it will look uncoordinated. Therefore, I naturally moved it to the right side.
Coincidentally, after I made the modification, I compared it with GitHub and found that they also have the same layout (it's purely a coincidence).

@silverwind
Copy link
Member

silverwind commented Feb 21, 2025

Imho, you want to modify template repo/issue/navbar so its consistent in all places. We shouldn't be singling out the repo issue page like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants