-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable vet
as part of go test
#33662
base: main
Are you sure you want to change the base?
Conversation
`go vet` implicitely runs as part of `go test`, but we already have `make lint-go-vet`. Ref: https://pkg.go.dev/cmd/go#hdr-Test_packages
Actually I see we ran
So I've added a command that now runs plain |
Need to check whether |
On a lower powered machine this definitely helps. |
Yeah I agree, |
go vet
implicitely runs as part ofgo test
, but we already havemake lint-go-vet
, so we were essentially running it twice. This should hopefully makego test
slightly faster.Ref: https://pkg.go.dev/cmd/go#hdr-Test_packages