-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Github Theme to Gitea and Setting It as the Default Theme #33624
base: main
Are you sure you want to change the base?
Conversation
ac02e6c
to
fecd3e5
Compare
Hmm, the "official" themes should be managed in the Gitea's repo, because we refactor the frontend a lot, using external theme files will break frequently. |
@wxiaoguang Yes, this PR was never intended to be merged into the main branch. It was simply provided as a reference example for custom theme packaging. |
For the record: If the default theme is ever changed, a database migration needs to be added to migrate users that had the previous theme set get migrated to the new theme. |
I think it is not needed anymore in modern Gitea. I have made the theme system could work with fallback correctly in Initial support for colorblindness-friendly themes (#30625) |
You mean users that select the default theme will store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please disregard this "review", it is solely to ensure that it can't be accidentally merged
Oh neat! I don't think I've seen this custom theme yet (I will have to take a double check of the "awesome" list), but it's rather exciting! |
Presumptuous Attempt, Do Not Merge
Include https://github.com/lutinglt/gitea-github-theme in Gitea and set it as default theme.