Fixed validation name of access token when creating #33614
+33
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/translation
modifies/templates
|
TBH, this Vue component is an anti-pattern (well, yes, from the beginning .....) So if there is a chance, I would suggest to refactor the form to make it work like a modern one. |
|
@wxiaoguang I'm new to this project. Could you give an example template that is modern :D? |
|
Maybe either completely remove the Vue component (TBH I do not see why it really helps in this case, since it doesn't do MVVM/React data binding), or completely use the Vue component for the form, but not let a component depends on its parent (out of scope) elements. Personally I prefer the first solution (completely remove the Vue component) if it is feasible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33519
Token name validation was skipped despite the required attribute because it was "taken over" by component vue. Component vue has been extended.