Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give organisation members access to organisation feeds #33508

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

job79
Copy link

@job79 job79 commented Feb 5, 2025

Currently the organisation feed only includes items for public repositories (for non-administrators). This pull requests adds notifications from private repositories to the organisation-feed (for accounts that have access to the organisation).

Feed-items only get shown for repositories where the users team(s) should have access to, this filtering seems to get done by some existing code.

Needs some tests, but am unsure where/how to add them.

Before:
image

After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 5, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 5, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 5, 2025
@wxiaoguang
Copy link
Contributor

Needs some tests, but am unsure where/how to add them.

Hmm yes ..... I guess it does need tests (and yes it's not that easy to write one ......) 🤣

@job79 job79 marked this pull request as draft February 13, 2025 09:48
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants