Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the installation page #32994

Merged
merged 6 commits into from
Dec 31, 2024
Merged

Optimize the installation page #32994

merged 6 commits into from
Dec 31, 2024

Conversation

kerwin612
Copy link
Member

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 26, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 26, 2024
@github-actions github-actions bot added modifies/translation modifies/templates This PR modifies the template files labels Dec 26, 2024
@kerwin612 kerwin612 requested a review from lunny December 26, 2024 14:24
@lunny
Copy link
Member

lunny commented Dec 26, 2024

Could you post a screenshot?

@kerwin612
Copy link
Member Author

kerwin612 commented Dec 27, 2024 •
edited
Loading

Could you post a screenshot?

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2024
@wxiaoguang
Copy link
Contributor

I would say the UI looks more ugly than before, these "installing" texts are just redundancy, and the sizes (font/image) are uncoordinated.

Since there is already an animation, I do not see why adding more sentences makes sense.

@kerwin612
Copy link
Member Author

I would say the UI looks more ugly than before, these "installing" texts are just redundancy, and the sizes (font/image) are uncoordinated.

Since there is already an animation, I do not see why adding more sentences makes sense.

image
Title, animation, description; not conflicting...

@wxiaoguang
Copy link
Contributor

Title, animation, description; not conflicting...

Your sample screenshot is well-designed and good-looking. And it does provide more details about each step, not just keep saying "installing" again and again.

delvh
delvh approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the short fix.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2024
wxiaoguang
wxiaoguang requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't look good to me

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Dec 27, 2024
@techknowlogick
Copy link
Member

I apologize if this is getting into yak-shaving territory.

I think having both "installing" and "please wait" is important, as even though there is the animation, for screen-readers they won't see that animation. This way, they'll know there is something happening that they need to wait for.

@wxiaoguang
Copy link
Contributor

I apologize if this is getting into yak-shaving territory.

I think having both "installing" and "please wait" is important, as even though there is the animation, for screen-readers they won't see that animation. This way, they'll know there is something happening that they need to wait for.

At least, the page should be well-designed and good-looking. But not adding more and more uncoordinated elements.

Have you ever seen other websites or apps use such layout ? Small font, large icon, small font, keep repeating "installing", and visually misaligned?

@techknowlogick
Copy link
Member

Have you ever seen other websites or apps use such layout ? Small font, large icon, small font, keep repeating "installing", and visually misaligned?

oh, my comment was just on the page's contents and not on the layout at all.

@wxiaoguang
Copy link
Contributor

Have you ever seen other websites or apps use such layout ? Small font, large icon, small font, keep repeating "installing", and visually misaligned?

oh, my comment was just on the page's contents and not on the layout at all.

Yes, I agree to improve the page, and I have said in #32994 (comment) : the new page should be good-looking, the "installing" content should be concise but not repeat twice.

@kerwin612
Copy link
Member Author

l1
l2

@wxiaoguang Is this OK?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 31, 2024 •
edited
Loading

@wxiaoguang Is this OK?

Yes, much better than before, looks good to me. (maybe it needs to fine tune the icon size, but it should be easy to do so)

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 31, 2024
@kerwin612
Copy link
Member Author

@wxiaoguang Is this OK?

Yes, much better than before, looks good to me. (maybe it needs to fine tune the icon size, but it should be easy to do so)

ok, icon resized slightly, I have commited.

@kerwin612 kerwin612 requested a review from wxiaoguang December 31, 2024 02:20
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 31, 2024 •
edited
Loading

Thank you very much for improving the page.

I did some tests on my side, and I think some HTML element could be optimized too since we do not need them.

And we can add aria-hidden="true" to the image, then no need to set "alt" or expose it to screen reader.

image

@wxiaoguang wxiaoguang force-pushed the optimize_install_page branch from 0c527e1 to 19db8cb Compare December 31, 2024 03:51
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Dec 31, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 31, 2024
@lunny lunny added this to the 1.24.0 milestone Dec 31, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 31, 2024 04:06
@wxiaoguang wxiaoguang merged commit 54bd220 into go-gitea:main Dec 31, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 31, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 2, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9754baf 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  unset XDG_HOME_CONFIG as gitea manages configuration locations (go-gitea#33067)
  Refactor repo-new.ts (go-gitea#33070)
  Refactor pull-request compare&create page (go-gitea#33071)
  feat: link to nuget dependencies (go-gitea#26554)
  Remove some unnecessary template helpers (go-gitea#33069)
  Inherit submodules from template repository content (go-gitea#16237)
  [skip ci] Updated translations via Crowdin
  feat(action): issue change title notifications (go-gitea#33050)
  Use project's redirect url instead of composing url (go-gitea#33058)
  Fix unittest and repo create bug (go-gitea#33061)
  Fix locale type (go-gitea#33059)
  Refactor maven package registry (go-gitea#33049)
  Optimize the installation page (go-gitea#32994)
  [Feature] Private README.md for organization (go-gitea#32872)
  Make issue suggestion work for new PR page (go-gitea#33035)
  Add IntelliJ Gateway's .uuid to gitignore (go-gitea#33052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files modifies/translation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kerwin612 @lunny @wxiaoguang @techknowlogick @delvh @GiteaBot