Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor render system #32492

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Refactor render system #32492

merged 4 commits into from
Nov 14, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 13, 2024 •
edited
Loading

There were too many patches to the Render system, it's really difficult to make further improvements.

This PR clears the legacy problems and fix TODOs.

  1. Rename RenderContext.Type to RenderContext.MarkupType to clarify its usage.
  2. Use ContentMode to replace meta["mode"] and IsWiki, to clarify the rendering behaviors.
  3. Use "wiki" mode instead of "mode=gfm + wiki=true"
  4. Merge renderByType and renderByFile
  5. Add more comments

The problem of "mode=document": in many cases it is not set, so many non-comment places use comment's hard line break incorrectly

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 13, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 13, 2024
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 13, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/frontend labels Nov 13, 2024
@wxiaoguang wxiaoguang force-pushed the refactor-render branch 7 times, most recently from 6ea7b24 to deca667 Compare November 13, 2024 11:55
@wxiaoguang wxiaoguang requested a review from lunny November 14, 2024 03:51
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 14, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) November 14, 2024 04:29
@wxiaoguang wxiaoguang merged commit 3f9c3e7 into go-gitea:main Nov 14, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 14, 2024
@wxiaoguang wxiaoguang deleted the refactor-render branch November 14, 2024 05:05
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6332a5e 
* giteaofficial/main:
  Refactor render system (go-gitea#32492)
  Fix nil panic if repo doesn't exist (go-gitea#32501)
  Bump CI,Flake and Snap to Node 22 (go-gitea#32487)
  Perf: add extra index to notification table (go-gitea#32395)
  Fix LFS route mock, realm, middleware names (go-gitea#32488)
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Nov 14, 2024
@lunny lunny mentioned this pull request Nov 15, 2024
Closed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 15, 2024
@zjjhot
Revert "Refactor render system (go-gitea#32492)"
94fd668 
This reverts commit 3f9c3e7.
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 17, 2024
@zjjhot
Reapply "Refactor render system (go-gitea#32492)"
d1df5e1 
This reverts commit 94fd668.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/frontend modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @Zettat123 @GiteaBot