Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong last modify time (#32102) #32104

Merged
merged 4 commits into from
Sep 22, 2024
Merged

Fix wrong last modify time (#32102) #32104

merged 4 commits into from
Sep 22, 2024
+8 −3

Conversation

GiteaBot
Copy link
Collaborator

Backport #32102 by @lunny

Fix #31930 and more places which use http.TimeFormat wrongly. http.TimeFormat requires a UTC time. refer to https://pkg.go.dev/net/http#TimeFormat

@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug labels Sep 21, 2024
@GiteaBot GiteaBot added this to the 1.22.3 milestone Sep 21, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 21, 2024
@GiteaBot GiteaBot requested review from delvh and lafriks September 21, 2024 21:56
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 21, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 22, 2024
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 22, 2024
@lunny lunny enabled auto-merge (squash) September 22, 2024 18:44
@lunny lunny merged commit af0cab2 into go-gitea:release/v1.22 Sep 22, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 22, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees

@lunny lunny

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.3
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @lafriks @yardenshoham