Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Account Linking UpdateMigrationsByType #31428

Merged
merged 8 commits into from
Jun 20, 2024
Merged

[Fix] Account Linking UpdateMigrationsByType #31428

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e610a6e
Change column data type to numeric to accomodate large numbers
Sumit189 Jun 19, 2024
7a7b458
Convert original_author_id column data type to numeric
Sumit189 Jun 19, 2024
b2d0c50
fmt changes
Sumit189 Jun 19, 2024
8547ab5
Convert UID to String
Sumit189 Jun 20, 2024
9f7a08d
Merge branch 'main' into oauth_linking_fix
Sumit189 Jun 20, 2024
4bca32c
Revert "Convert UID to String"
Sumit189 Jun 20, 2024
9cf1bf8
return if parse fails
Sumit189 Jun 20, 2024
c949e03
update comment
Sumit189 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions services/externalaccount/user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package externalaccount

import (
"context"
"strconv"
"strings"

"code.gitea.io/gitea/models/auth"
Expand Down Expand Up @@ -82,6 +83,11 @@ func UpdateExternalUser(ctx context.Context, user *user_model.User, gothUser got

// UpdateMigrationsByType updates all migrated repositories' posterid from gitServiceType to replace originalAuthorID to posterID
func UpdateMigrationsByType(ctx context.Context, tp structs.GitServiceType, externalUserID string, userID int64) error {
// Skip update if externalUserID is not a valid numeric ID or exceeds int64
if _, err := strconv.ParseInt(externalUserID, 10, 64); err != nil {
return nil
}

if err := issues_model.UpdateIssuesMigrationsByType(ctx, tp, externalUserID, userID); err != nil {
return err
}
Expand Down