Fix bugs when concurrent pushing packages #30335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
pull-request-size
bot
added
size/M
silverwind
reviewed
Apr 8, 2024
pull-request-size
bot
added
size/L
|
I encountered a probelm which mentioned in https://github.com/go-gitea/gitea/pull/16510/files#r836054699 . Since there is no unique keys on |
tlusser
reviewed
Apr 16, 2024
| defer tests.PrintCurrentTest(t)() | ||
|
|
||
| var wg sync.WaitGroup | ||
| for i := 0; i < 10; i++ { |
There was a problem hiding this comment.
I think this test is not correct - it should look like:
`
for i := 0; i < 10; i++ {
wg.Add(1)
go func(i int) {
putFile(t, fmt.Sprintf("/%s/%s.jar", packageVersion, strconv.Itoa(i)), "test", http.StatusCreated)
wg.Done()
}(i)
}
`
tlusser
reviewed
Apr 16, 2024
| return nil, err | ||
| } | ||
| case setting.Database.Type.IsPostgreSQL(), setting.Database.Type.IsSQLite3(): | ||
| if _, err := db.GetEngine(ctx).Exec("INSERT INTO package (owner_id,`type`,lower_name,name,semver_compatible) VALUES (?,?,?,?,?) ON CONFLICT (owner_id,`type`,lower_name) DO UPDATE SET lower_name=lower_name", |
There was a problem hiding this comment.
I think this line should look like:
"INSERT INTO package (owner_id,type,lower_name,name,semver_compatible) VALUES (?,?,?,?,?) ON CONFLICT (owner_id,type,lower_name) DO UPDATE SET lower_name=EXCLUDED.lower_name"
lunny
changed the title
This was referenced May 7, 2024
Closed
|
Close as it is outdated. A lock from #31851 has been added to fix the concurrent pushing bug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30171