Remove jQuery .attr from the label edit exclusive checkbox
#30053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched from jQuery `attr` to plain javascript `getAttribute` - Tested the label edit exclusive checkbox and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
yardenshoham
added
the
type/refactoring
silverwind
approved these changes
Mar 24, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Mar 24, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 25, 2024
* origin/main: Remove fomantic table module (go-gitea#30047) Fix menu buttons in issues and release (go-gitea#30056) Fix git grep search limit, add test (go-gitea#30071) Fix button hover border (go-gitea#30048) Fix Add/Remove WIP on pull request title failure (go-gitea#29999) Fix misuse of `TxContext` (go-gitea#30061) Remove jQuery `.attr` from the reaction selector (go-gitea#30052) Remove jQuery `.attr` from the ComboMarkdownEditor (go-gitea#30051) Remove jQuery `.attr` from the label edit exclusive checkbox (go-gitea#30053) Remove jQuery `.attr` from the repository topic bar (go-gitea#30050) Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (go-gitea#29990) Migrate `gt-hidden` to `tw-hidden` (go-gitea#30046) Forbid jQuery `is` and fix issues (go-gitea#30016) Remove fomantic segment module (go-gitea#30042) Migrate margin and padding helpers to tailwind (go-gitea#30043)
wxiaoguang
reviewed
Dec 7, 2024
| if (isExclusiveScopeName(nameInput.value)) { | ||
| exclusiveField?.classList.remove('muted'); | ||
| exclusiveField?.removeAttribute('aria-disabled'); | ||
| if (exclusiveCheckbox.checked && exclusiveCheckbox.getAttribute('data-exclusive-warn')) { |
There was a problem hiding this comment.
Here is a regression bug, the code below uses $exclusiveCheckbox.data('exclusive-warn', ... and can't be read by getAttribute
There was a problem hiding this comment.
.data("foo") is equivalent to .getAttribute("data-foo") for plain string data, no?
There was a problem hiding this comment.
getAttribute('data-foo') can't read $().data('foo', 'value'), see below $exclusiveCheckbox.data('exclusive-warn',...)
There was a problem hiding this comment.
Ah indeed. I forgot that .data() does not actually write HTML attributes. Should have refactored the whole file.
There was a problem hiding this comment.
-> Refactor LabelEdit #32752
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attrto plain javascriptgetAttribute