Support requested_reviewers data in comment webhook events #26178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
Makonike
changed the title
lunny
reviewed
Sep 24, 2024
Makonike
force-pushed
the
feature/webhook_reviewers_data
branch
from
923bb52 to
4156990
Compare
lunny
reviewed
Sep 24, 2024
lunny
reviewed
Sep 25, 2024
lunny
approved these changes
Sep 26, 2024
GiteaBot
added
lgtm/need 1
wolfogre
approved these changes
Oct 15, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 17, 2024
* giteaofficial/main: Warn users when they try to use a non-root-url to sign in/up (go-gitea#32272) Fix null errors on conversation holder (go-gitea#32258) (go-gitea#32266) Support requested_reviewers data in comment webhook events (go-gitea#26178)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #25833
Currently, the information for "requested_reviewers" is only included in the webhook event for reviews. I would like to suggest adding this information to the webhook event for "PullRequest comment" as well, as they both pertain to the "PullRequest" event.
Also, The reviewer information for the Pull Request is not displayed when it is approved or rejected.