Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'Privacy' section in profile settings #25309

Merged
merged 7 commits into from
Jun 22, 2023

Conversation

n0toose
Copy link
Contributor

@n0toose n0toose commented Jun 16, 2023

  • Improve "Hide the activity from the profile page" label
  • E-Mail privacy icon in user profile now redirects to Privacy section
  • E-Mail privacy settings moved to Privacy section

Previously, the user was redirected to the setting itself, however,
that is not a good design choice because the setting itself would
be at the very top of the user's browser window. This fix doesn't
fix the problem entirely, but it is definitely an improvement
compared to its previous iteration.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 16, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2023
@n0toose
Copy link
Contributor Author

n0toose commented Jun 16, 2023

image

I find this change to make more sense, as it brings everything together in one place and if the user decides to e.g. click on the lock icon in the profile, they get to see other privacy-related settings as well.

image

However, it feels a bit odd, as this checkbox appears at the very top of the screen and not at the place that the user is looking at; do I redirect them to the Privacy section (push new commit), or that specific setting (do nothing)?

EDIT: I went for the new commit. I'm not planning to increase the scope of this PR any further.

@silverwind
Copy link
Member

silverwind commented Jun 17, 2023

Just edit the original comment description please, it will be fully preserved in the commit message on merge and it's semi-important that this info is part of the commit.

Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM except the nit.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2023
@lunny lunny added this to the 1.21.0 milestone Jun 21, 2023
6543 and others added 2 commits June 22, 2023 09:47
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 22, 2023
@6543 6543 enabled auto-merge (squash) June 22, 2023 07:50
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 22, 2023
@6543 6543 merged commit ff90c87 into go-gitea:main Jun 22, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 22, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 20, 2023
@denyskon denyskon added the type/enhancement An improvement of existing functionality label Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants