-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve 'Privacy' section in profile settings #25309
Conversation
I find this change to make more sense, as it brings everything together in one place and if the user decides to e.g. click on the lock icon in the profile, they get to see other privacy-related settings as well. However, it feels a bit odd, as this checkbox appears at the very top of the screen and not at the place that the user is looking at; do I redirect them to the Privacy section (push new commit), or that specific setting (do nothing)? EDIT: I went for the new commit. I'm not planning to increase the scope of this PR any further. |
Just edit the original comment description please, it will be fully preserved in the commit message on merge and it's semi-important that this info is part of the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM except the nit.
Co-authored-by: silverwind <me@silverwind.io>
Previously, the user was redirected to the setting itself, however,
that is not a good design choice because the setting itself would
be at the very top of the user's browser window. This fix doesn't
fix the problem entirely, but it is definitely an improvement
compared to its previous iteration.