Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord "Commit Status" Webhooks Are Broken #33603

Closed
TheBrokenRail opened this issue Feb 15, 2025 · 0 comments · Fixed by #33620
Closed

Discord "Commit Status" Webhooks Are Broken #33603

TheBrokenRail opened this issue Feb 15, 2025 · 0 comments · Fixed by #33620
Labels
topic/webhooks type/bug
Milestone
1.23.4

Comments

@TheBrokenRail
Copy link
Contributor

TheBrokenRail commented Feb 15, 2025 •
edited
Loading

Description

Gitea's commit status webhooks are malformed and thus rejected by Discord. This is because it only provides a relative URL (like /minecraft-pi-reborn/runtime/actions/runs/7/jobs/1) instead of a full URL (like https://gitea.thebrokenrail.com/minecraft-pi-reborn/runtime/actions/runs/7/jobs/1). The issue seems to be caused by this line.

Gitea Version

1.23.3

Can you reproduce the bug on the Gitea demo site?

Probably. But I do not have the time to set up an additional Gitea Actions runner just to test a webhook.

Log Gist

No response

Screenshots

After manually modifying the request, it worked:

Image

BTW this should probably just use the short commit hash.

Git Version

No response

Operating System

No response

How are you running Gitea?

Using the official Gitea Docker image.

Database

None
@lunny lunny added this to the 1.23.4 milestone Feb 15, 2025
@lunny lunny mentioned this issue Feb 17, 2025
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Feb 18, 2025
@lunny @wxiaoguang @GiteaBot
Make actions URL in commit status webhooks absolute (go-gitea#33620)
c1f5f53 
Gitea Actions generated target url doesn't contain host and port. So we
need to include them for external webhook visiting.

Fix go-gitea#33603

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot mentioned this issue Feb 18, 2025
Merged
wxiaoguang added a commit that referenced this issue Feb 18, 2025
@GiteaBot @lunny @wxiaoguang
Make actions URL in commit status webhooks absolute (#33620) (#33632)
b2707bc 
Backport #33620 by lunny

Fix #33603

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/webhooks type/bug
Projects
None yet
Milestone
1.23.4
Development

Successfully merging a pull request may close this issue.

Make actions URL in commit status webhooks absolute lunny/gitea
3 participants
@lunny @TheBrokenRail @kemzeb