Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Enter does not select highlighted Issue Label #33444

Closed
bartvdbraak opened this issue Jan 30, 2025 · 2 comments · Fixed by #33447
Closed

Pressing Enter does not select highlighted Issue Label #33444

bartvdbraak opened this issue Jan 30, 2025 · 2 comments · Fixed by #33447
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.23.2

Comments

@bartvdbraak
Copy link

bartvdbraak commented Jan 30, 2025 •
edited
Loading

Description

After upgrading Gitea 1.22.6 to 1.23.1, our triagers have encountered that labels can no longer be set by typing in the name and then pressing enter.

Steps to reproduce:

  1. Go to a issue or pull request
  2. On the right select the Labels text and you will have a option to change the labels.
  3. Type in a label you want (E.g. High for Serverity | High)
  4. Notice that the High severity label is highlighted, and press Enter to select it.
  5. Notice that the label doesn't get selected.

Gitea Version

1.23.1 built with GNU Make 4.4.1, go1.23.5 : bindata, timetzdata, sqlite, sqlite_unlock_notify

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Image

In the image above, pressing Enter won't select the highlighted issue label.

Git Version

2.47.2

Operating System

Ubuntu 24.04

How are you running Gitea?

Docker Compose with source of truth at https://github.com/blender/gitea

Database

PostgreSQL
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jan 30, 2025 •
edited
Loading

Maybe related to "make search box in issue sidebar dropdown list always show when scrolling #32576", it makes the dropdown lose keyboard support

@wxiaoguang wxiaoguang added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 30, 2025
@wxiaoguang wxiaoguang mentioned this issue Jan 30, 2025
Merged
@wxiaoguang
Copy link
Contributor

Could you try Fix issue dropdown sidebar keyboard support #33447 ?

@lunny lunny closed this as completed in b57d9f4 Jan 30, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jan 30, 2025
@wxiaoguang @GiteaBot
Fix issue sidebar dropdown keyboard support (go-gitea#33447)
d932b17 
Just a quick fix, fix go-gitea#33444
@GiteaBot GiteaBot mentioned this issue Jan 30, 2025
Merged
wxiaoguang added a commit that referenced this issue Jan 31, 2025
@GiteaBot @wxiaoguang
Fix issue sidebar dropdown keyboard support (#33447) (#33450)
9780da5 
Backport #33447 by wxiaoguang

Just a quick fix, fix #33444

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@lunny lunny added this to the 1.23.2 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.23.2
Development

Successfully merging a pull request may close this issue.

Fix issue sidebar dropdown keyboard support wxiaoguang/gitea
3 participants
@lunny @wxiaoguang @bartvdbraak