Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily workaround around toolchain bug #60

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Temporarily workaround around toolchain bug #60

merged 1 commit into from
Jul 11, 2018

Conversation

gnzlbg
Copy link
Owner

@gnzlbg gnzlbg commented Jul 11, 2018

This PR temporarily works around a toolchain bug.

@gnzlbg
Copy link
Owner Author

gnzlbg commented Jul 11, 2018

It appears that all build bots have recently started to fail... been scratching my head with another PR thinking it was my fault for a while... :D

cc @alexcrichton @SimonSapin @sfackler any ideas of why? maybe its time to move from cross to our own ci...

@gnzlbg gnzlbg changed the title test Temporarily workaround around toolchain bug Jul 11, 2018
@SimonSapin
Copy link
Contributor

This looks like definitely a Cargo bug, thanks for reporting it upstream at rust-lang/cargo#5708. I think it’s fine to temporarily disable this test if this Cargo bug is blocking some other work. Or maybe temporarily switch to the Beta channel? CC https://github.com/alexcrichton/jemallocator/issues/62

@gnzlbg
Copy link
Owner Author

gnzlbg commented Jul 11, 2018

I'll merge this to disable those tests temporarily and update the cargo issue upstream with the commit required to reproduce this. I'll send a different PR adding beta build bots for the tier 1 targets.

@alexcrichton
Copy link
Collaborator

I believe removing links should also do the trick (temporarily)

@gnzlbg
Copy link
Owner Author

gnzlbg commented Jul 11, 2018

Thanks for submitting a fix upstream! I think the two jemalloc-sys tests do not test that much actually, and removing links temporarily sounds dangerous if somebody is depending on jemallocator git :/

@gnzlbg gnzlbg merged commit a67a58d into gnzlbg:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants