Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamburger menu doesn't transition properly for Source List #30

Open
claude-peon opened this issue Oct 29, 2016 · 5 comments
Open

Hamburger menu doesn't transition properly for Source List #30

claude-peon opened this issue Oct 29, 2016 · 5 comments

Comments

@claude-peon
Copy link
Contributor

This is a strange bug. Here are some of the details of how to replicate the bug.

  1. Log in click the hamburger
  2. Click "Source List"
  • The hamburger will not transition when you do this
  • If you click the hamburger once more it will fix the problem
  • If you log out and log back in and follow steps 1 and 2 the hamburger transitions properly
  • If you click any other button in the drawer first you will not experience this bug
ausbin added a commit to ausbin/canteen-app that referenced this issue Oct 29, 2016
ausbin added a commit to ausbin/canteen-app that referenced this issue Oct 29, 2016
@ausbin
Copy link
Member

ausbin commented Oct 29, 2016

This seems to be a timing issue.

31096dc causes the arrow to freeze mid-transition, like this:

And while not a real fix, 6f56b38 fixes the issue entirely.

80b97ec appears to have triggered this, but I don't think it's to blame necessarily. Instead, I'll try to work #18, which should fix this.

@ausbin
Copy link
Member

ausbin commented Oct 29, 2016

ok, I lied, 80b97ec didn't do it, whoops. But fixing #18 should still fix this

ausbin added a commit to ausbin/canteen-app that referenced this issue Oct 30, 2016
@ausbin
Copy link
Member

ausbin commented Oct 30, 2016

Even after 3a9ee18 (aka #18, async api calls) this is still broken, so the slowdown must be either/both:

  1. Blocking on loading the view fxml (this would explain why it only screws up the first time)
  2. Populating the table, since d8bab4c "fixes" the issue

@claude-peon
Copy link
Contributor Author

claude-peon commented Oct 31, 2016

Lets try changing the api call to populate the list when the app is opened rather than when the list view is loaded up. The issue seems to be repeatable with the Purity List as well.

Nevermind. This won't help
=p

@ausbin
Copy link
Member

ausbin commented Nov 10, 2016

I'm assuming this is related to #47 since both occur only once, when the view is first loaded from fxml. Makes me think we need to load FXML ahead of time somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants