Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of docs #97

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Refactor of docs #97

merged 1 commit into from
Feb 21, 2018

Conversation

denisgranha
Copy link
Contributor

  • Wrap async/await functions for tutorial
  • Added a few comments
  • Removed example files (now all in docs)

@denisgranha denisgranha requested a review from cag February 21, 2018 19:03
Copy link
Contributor

@cag cag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just verify the change I am wondering about, and I will regenerate the docs and give it a test run.

)
console.info(`Ipfs hash: https://ipfs.infura.io/api/v0/cat?stream-channels=true&arg=${ipfsHash}`)
}
createDescription()
```

Of course, future events will come to pass, and once they do, the outcome should be determinable. Oracles report on the outcome of events. The simplest oracle contract provided by Gnosis is a [`CentralizedOracle`](https://gnosis.github.io/gnosis-contracts/docs/CentralizedOracle/), and it is controlled by a single entity: the `owner` of the contract, which is a single Ethereum address, and which will from this point forward in this guide be referred to as the centralized oracle itself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm this is left out intentionally?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird it appeared to be red in the diff... Okay everything is good then.

@cag cag merged commit e204160 into master Feb 21, 2018
@cag cag deleted the feature/DEV-129-refactor-docs branch February 21, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants