Update project references #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germartinez
commented
May 4, 2018
README.md
Outdated
|
|
||
| [](https://slack.gnosis.pm) | ||
|
|
||
| ## Getting Started | ||
|
|
||
| See the [documentation](https://gnosisjs.readthedocs.io/en/latest/). | ||
| See the [documentation](https://pm-js.readthedocs.io/en/latest/). |
There was a problem hiding this comment.
Be careful with this.
germartinez
commented
May 4, 2018
| @@ -31,7 +31,7 @@ async function createDescription () { | |||
| createDescription() | |||
| ``` | |||
|
|
|||
| Of course, future events will come to pass, and once they do, the outcome should be determinable. Oracles report on the outcome of events. The simplest oracle contract provided by Gnosis is a [`CentralizedOracle`](https://gnosis-contracts.readthedocs.io/en/latest/CentralizedOracle.html), and it is controlled by a single entity: the `owner` of the contract, which is a single Ethereum address, and which will from this point forward in this guide be referred to as the centralized oracle itself. | |||
| Of course, future events will come to pass, and once they do, the outcome should be determinable. Oracles report on the outcome of events. The simplest oracle contract provided by Gnosis is a [`CentralizedOracle`](https://pm-contracts.readthedocs.io/en/latest/CentralizedOracle.html), and it is controlled by a single entity: the `owner` of the contract, which is a single Ethereum address, and which will from this point forward in this guide be referred to as the centralized oracle itself. | |||
There was a problem hiding this comment.
Be careful with this.
germartinez
commented
May 4, 2018
| > ``` | ||
| > https://gnosisdb.rinkeby.gnosis.pm/api/events/EVENT_ADDRESS | ||
| > https://pm-trading-db.rinkeby.gnosis.pm/api/events/EVENT_ADDRESS |
There was a problem hiding this comment.
Be careful with this.
|
I'm gonna hold off for a moment so that all the RtD stuff can be finalized |
cag
force-pushed
the
update-project-references
branch
4 times, most recently
from
8b88896 to
8832aca
Compare
cag
approved these changes
May 7, 2018
| "nodebuild": "babel src/ --out-dir dist --source-maps", | ||
| "webbuild": "webpack && cross-env WEBPACK_ENV=minified webpack -p", | ||
| "dev": "run-with-testrpc 'npm run migrate && webpack-dev-server'", | ||
| "test": "run-with-testrpc -l 40000000 'npm run migrate && npm run test-manual'", | ||
| "test-manual": "multidep test/multidep.json && mocha --timeout 120000 --require babel-core/register $MOCHA_OPTS", | ||
| "test-gnosisdb": "cross-env GNOSIS_OPTIONS='{\"ipfs\":{\"host\":\"localhost\",\"port\":5001,\"protocol\":\"http\"}}' npm run test-manual", | ||
| "test-pm-trading-db": "cross-env GNOSIS_OPTIONS='{\"ipfs\":{\"host\":\"localhost\",\"port\":5001,\"protocol\":\"http\"}}' npm run test-manual", |
There was a problem hiding this comment.
@denisgranha Gotta remember about this script name change...
| @@ -92,8 +92,8 @@ describe('Gnosis', function () { | |||
|
|
|||
| await gnosis.setWeb3Provider(ganache.provider({ network_id: 4 })) | |||
|
|
|||
| assert.equal(gnosis.olympiaToken.address, '0xa0c107db0e9194c18359d3265289239453b56cf2') | |||
| assert.equal(gnosis.olympiaAddressRegistry.address, '0x79da1c9ef6bf6bc64e66f8abffddc1a093e50f13') | |||
| assert.equal(gnosis.olympiaToken.address, '0x979861df79c7408553aaf20c01cfb3f81ccf9341') | |||
There was a problem hiding this comment.
I know these changed upstream... I can't remember if that was intentional 😅
cag
force-pushed
the
update-project-references
branch
from
8832aca to
3bbd6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to be consistent with the new project names.
package-lock.json and
/distmust be regenerated.