Skip to content

New Action API #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 20, 2022
Merged

New Action API #39

merged 5 commits into from
Feb 20, 2022

Conversation

eugener
Copy link
Collaborator

@eugener eugener commented Feb 19, 2022

Functionality

  • refactor API to actions/action factory, which can be exposed in control
  • actions are now used in the demo
  • added ikonli for the demo purposes.

Closes #35

Future directions

  • implement action state, which will allow for example to automatically enable/disable toolbar controls based on on the state of the editor.

@eugener eugener added the enhancement New feature or request label Feb 19, 2022
jperedadnr
jperedadnr approved these changes Feb 20, 2022
View reviewed changes
Copy link
Collaborator

@jperedadnr jperedadnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. There are some underlying issues with selection and decoration, but can be tackled after merging this PR.

@eugener
Copy link
Collaborator Author

eugener commented Feb 20, 2022 •
edited
Loading

Yes, still a lot of issues. This PR is about exposing actions all the way to the control level

@eugener eugener merged commit 1d450e5 into gluonhq:master Feb 20, 2022
@abhinayagarwal abhinayagarwal mentioned this pull request Feb 21, 2022
Closed
jperedadnr pushed a commit to jperedadnr/rich-text-area that referenced this pull request Jul 11, 2023
@abhinayagarwal
Add support for Channels (gluonhq#39)
b0d1da5
jperedadnr added a commit to jperedadnr/rich-text-area that referenced this pull request Jul 11, 2023
@jperedadnr
Use custom data format for clipboard operations (gluonhq#39)
1a59a91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jperedadnr jperedadnr jperedadnr approved these changes

@abhinayagarwal abhinayagarwal Awaiting requested review from abhinayagarwal

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design & implementation of public editor actions
2 participants
@eugener @jperedadnr